Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a method for feedback widget segmentation #438

Merged
merged 13 commits into from
Nov 9, 2023

Conversation

turtledreams
Copy link
Contributor

No description provided.

Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let’s pass segmentation as part of the present call

Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the custom object

@turtledreams
Copy link
Contributor Author

* */
this.present_feedback_widget = function(presentableFeedback, id, className) {
log(logLevelEnums.INFO, "[present_feedback_widget] Presenting the feedback widget by appending to the element with ID: [ " + id + " ] and className: [ " + className + " ]");
this.present_feedback_widget = function(presentableFeedback, id, className, feedbackWidgetSegmentation) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case "id" and "class name" are not used, what value should be provided. should be mentioned in the function doc

@ArtursKadikis ArtursKadikis merged commit 8fca557 into staging Nov 9, 2023
1 of 4 checks passed
@ArtursKadikis ArtursKadikis deleted the feedback-widget-segmentation branch November 9, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants